Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated text to Copy clean link #15518

Merged
merged 1 commit into from
Oct 18, 2022
Merged

Updated text to Copy clean link #15518

merged 1 commit into from
Oct 18, 2022

Conversation

spylogsster
Copy link
Contributor

@spylogsster spylogsster commented Oct 18, 2022 •
edited by kjozwiak
Loading

Resolves brave/brave-browser#26106
Resolves brave/brave-browser#25621

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

@spylogsster spylogsster self-assigned this Oct 18, 2022
@spylogsster spylogsster added this to the 1.46.x - Nightly milestone Oct 18, 2022
bsclifton
bsclifton approved these changes Oct 18, 2022
View reviewed changes
Copy link
Member

@bsclifton bsclifton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

@spylogsster spylogsster enabled auto-merge (squash) October 18, 2022 21:11
@spylogsster spylogsster merged commit a893ee5 into master Oct 18, 2022
@spylogsster spylogsster deleted the brave-26106 branch October 18, 2022 22:32
@spylogsster spylogsster restored the brave-26106 branch October 22, 2022 15:25
brave-builds pushed a commit that referenced this pull request Oct 22, 2022
@brave-browser-releases
Uplift of #15518 (squashed) to beta
b3caaec
@brave-builds brave-builds mentioned this pull request Oct 22, 2022
Merged
7 tasks
@spylogsster spylogsster mentioned this pull request Oct 22, 2022
Merged
7 tasks
@kjozwiak
Copy link
Member

Verification PASSED on Win 11 x64 using the following build(s):

Brave | 1.47.10 Chromium: 107.0.5304.62 (Official Build) nightly (64-bit)
-- | --
Revision | 1eec40d3a5764881c92085aaee66d25075c159aa-refs/branch-heads/5304@{#942}
OS | Windows 11 Version 22H2 (Build 22621.675)

As per brave/brave-browser#26106 (comment), ensured that the text/string appeared as per the following:

  • Copy clean link via the Share button on the URL bar
  • Copy clean link via the right click context menu when URL has been selected
Example (Share menu) Example (Context menu)
copyCleanLink1 copyCleanLink2

@kjozwiak kjozwiak deleted the brave-26106 branch October 24, 2022 03:24
@kjozwiak kjozwiak mentioned this pull request Oct 24, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fmarier fmarier fmarier approved these changes

@bsclifton bsclifton bsclifton approved these changes

Assignees

@spylogsster spylogsster

Labels
None yet
Projects
None yet
Milestone
1.47.x - Release
Development

Successfully merging this pull request may close these issues.

update text to Copy clean link Better wording for Copy Clean URL context menu item
4 participants
@spylogsster @kjozwiak @fmarier @bsclifton